ethrpc: preserve non-batch errors in BatchCall#213
Open
pengqima wants to merge 1 commit into
Open
Conversation
Signed-off-by: pengqima <pengqima@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve the original error returned by
Provider.DowhenBatchCallreceives an error that is not aBatchError.The previous type assertion reused the name
err:When the assertion failed, the else branch referred to the zero value produced by the failed assertion instead of the original error. This resulted in an empty error such as:
unable to batch call:It also prevented callers from inspecting the underlying error with errors.Is.
The asserted value is now named batchErr, allowing the non-batch branch to wrap the original error. Existing BatchError handling remains unchanged.
A regression test uses a failing HTTP client to verify that the transport error remains in the returned error chain.